FIX: Removing dependencies on VRModule #2251
Open
+1
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "name": "com.unity.modules.vr", | ||
| "expression": "1.0.0", | ||
| "define": "UNITY_INPUT_SYSTEM_ENABLE_VR" |
There was a problem hiding this comment.
should we also need to remove code that utilize UNITY_INPUT_SYSTEM_ENABLE_VR?
There was a problem hiding this comment.
There were no code paths left in the InputSystem or Engine repository that utilized the define UNITY_INPUT_SYSTEM_ENABLE_VR
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2251 +/- ##
========================================
Coverage 76.70% 76.71%
========================================
Files 465 465
Lines 87919 87911 -8
========================================
- Hits 67442 67440 -2
+ Misses 20477 20471 -6 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…System into vrmodule-deprecation
Tanya-Li-Unity
approved these changes
Oct 3, 2025
|
|
RogPodge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The VR Module is obsolete and slated to be removed in a future version of Unity: https://docs.unity3d.com/6000.3/Documentation/ScriptReference/UnityEngine.VRModule.html
This PR removes the dependency of the Input System Package from the VR Module. There is one functional change to the PR, where the AutoXRCameraTracking is disabled during
AwakeandOnDestroy. This function only works when using the Legacy XR Framework, and does nothing when using the modern XR architecture.Testing status & QA
N/A
Overall Product Risks
Comments to reviewers
Removal of the dependency on the VR Module will help make the full removal of the VR Module easier in the future.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: